This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH][BZ #18441] fix sorting multibyte charsets with an improper locale
- From: Andreas Schwab <schwab at linux-m68k dot org>
- To: OndÅej BÃlka <neleai at seznam dot cz>
- Cc: Leonhard Holz <leonhard dot holz at web dot de>, libc-alpha at sourceware dot org
- Date: Sun, 28 Jun 2015 13:59:16 +0200
- Subject: Re: [PATCH][BZ #18441] fix sorting multibyte charsets with an improper locale
- Authentication-results: sourceware.org; auth=none
- References: <558EA828 dot 3080106 at web dot de> <20150627190422 dot GA7128 at domone> <87ioa8vrt6 dot fsf at igel dot home> <20150627205632 dot GA14937 at domone> <87egkwvn1p dot fsf at igel dot home> <20150628061844 dot GA16633 at domone>
OndÅej BÃlka <neleai@seznam.cz> writes:
> On Sat, Jun 27, 2015 at 11:50:10PM +0200, Andreas Schwab wrote:
>> OndÅej BÃlka <neleai@seznam.cz> writes:
>>
>> > On Sat, Jun 27, 2015 at 10:07:17PM +0200, Andreas Schwab wrote:
>> >> OndÅej BÃlka <neleai@seznam.cz> writes:
>> >>
>> >> > *((uint16_t *) runp->mbs)
>> >> > (index << 12) ^ *((uint16_t *) (runp->mbs+1));
>> >>
>> >> Either of these will be unaligned.
>> >>
>> > Which as its used to index array of size 256 * 256 is what we want.
>>
>> This doesn't make any sense.
>>
> Yes, was writing that while bit drunk so I somewhat read that as unsigned.
> These should be guarded with_STRING_ARCH_unaligned.
localedef doesn't need micro-optimizations.
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."