This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Clean pthread functions namespace for C11 threads
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Juan Manuel Torres Palma <j dot m dot torrespalma at gmail dot com>
- Cc: libc-alpha <libc-alpha at sourceware dot org>
- Date: Fri, 26 Jun 2015 20:48:41 +0000
- Subject: Re: [PATCH] Clean pthread functions namespace for C11 threads
- Authentication-results: sourceware.org; auth=none
- References: <CAD82F-qqDtxPM3biUmo8BCxNisk0Fbh2=irH_9P3P75+osJRrg at mail dot gmail dot com> <alpine dot DEB dot 2 dot 10 dot 1506252149520 dot 1497 at digraph dot polyomino dot org dot uk> <CAD82F-r76WGSGpu5UurEiCORfQxt9ezZ6PZt932LSDJryqPm3w at mail dot gmail dot com>
On Fri, 26 Jun 2015, Juan Manuel Torres Palma wrote:
> It's true that during the implementation of mtx_init, I had to use
> pthread_mutexattr_init and pthread_mutex_settype, that weren't
> initially in my plans. Do you think more functions are affected apart
> from these?
Part of the C11 threads implementation process should be adding threads.h
to the conform/ test coverage. That means conform/data/threads.h-data
matching C11 requirements; adding threads.h to conformtest-headers-ISO11
in conform/Makefile; ensuring that linknamespace-libs-ISO11 includes any
libraries required for the C11 threads functions. Then, make sure the
tests for ISO11 all pass; any linknamespace failures for threads.h
indicate cases where you need to call __* names with the public names
being weak aliases. That will help you catch any non-obvious cases where
the call to a non-C11 function might be at several levels of indirection
from the C11 threads implementation.
--
Joseph S. Myers
joseph@codesourcery.com