This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 7/14] [x86_64] Vector math functions (log and tests)
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Andrew Senkevich <andrew dot n dot senkevich at gmail dot com>
- Cc: libc-alpha <libc-alpha at sourceware dot org>
- Date: Mon, 15 Jun 2015 22:14:36 +0000
- Subject: Re: [PATCH 7/14] [x86_64] Vector math functions (log and tests)
- Authentication-results: sourceware.org; auth=none
- References: <CAMXFM3uCX8KS=pr+ugD7aSgWs4rTfw=NqQkpYY6m7cQnnbYYPA at mail dot gmail dot com> <alpine dot DEB dot 2 dot 10 dot 1506041735260 dot 12011 at digraph dot polyomino dot org dot uk> <CAMXFM3tKbkAaxJbApGFZL0U9+sT_tGe2P0ZW57yRy1BMyKcjwA at mail dot gmail dot com> <alpine dot DEB dot 2 dot 10 dot 1506051631200 dot 26931 at digraph dot polyomino dot org dot uk> <CAMXFM3sZLo5_KV_wc6fFwV0h5yNYegPan5anh_kfSsLgrKUzfA at mail dot gmail dot com> <CAMXFM3tQb95rgZK1Fwo8Dg=pJn_fuQqMf6s2-d7pjoiatE8KJw at mail dot gmail dot com> <alpine dot DEB dot 2 dot 10 dot 1506112145070 dot 15628 at digraph dot polyomino dot org dot uk> <CAMXFM3s7kqr6pV1rxu9c0w-DwBe+QQ03tgx3YAf8j9dVXcPXGw at mail dot gmail dot com>
On Mon, 15 Jun 2015, Andrew Senkevich wrote:
> 2015-06-12 0:47 GMT+03:00 Joseph Myers <joseph@codesourcery.com>:
> > On Wed, 10 Jun 2015, Andrew Senkevich wrote:
> >
> >> +/* Workaround to exclude unnecessary symbol aliases in libmvec
> >> + while GCC creates the vector names based on scalar asm name. */
> >
> > I think the GCC list discussion of possible better approaches to this
> > issue should be started first, with the comment referencing the
> > discussion.
> >
> >> + movsd -4218816(%r8,%rdx), %xmm1
> >
> > Where does this magic constant -4218816, that appears several times in the
> > patch, come from? It seems like something that should have a #define in a
> > header, with a meaningful name and a comment explaining its semantics.
>
> Attached patch contains these parts updated. Ok?
OK.
--
Joseph S. Myers
joseph@codesourcery.com