Re: [PATCH] powerpc: strcasestr optimization

[Roland McGrath <roland at hack dot frob dot com>]

> If Ond ej Bílka believes there is a problem that only he understands
> then the onus is on him to provide the appropriate benchmark.

Agreed.  It's reasonable to hold up the change based on announced intent to
quickly supply a benchmark that changes the available objective analysis of
the change's performance effect.  But if the objector doesn't commit to
delivering that benchmark soon, then he doesn't have grounds to object to
the change.  

OTOH, if it's the case that the only benchmarks we have for a particular
function are very poor representatives and the consensus agrees on that
assessment, then it's reasonable to demand that better benchmarks be
achieved before changes claimed to improve performance of that function can
be entertained.  (I don't know if that's the situation here; I'm just
talking about the general policy of the project.)

In short, if you intend either to propose a lot of performance-improvement
changes or to be skeptical of such proposals by others, then you should
expect to spend a lot of effort on writing better benchmarks and reaching
consensus on their quality.


Thanks,
Roland