This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] AArch64/ILP32: fix wrong sign extension in setgroups
- From: Roland McGrath <roland at hack dot frob dot com>
- To: Andreas Schwab <schwab at suse dot de>
- Cc: libc-alpha at sourceware dot org
- Date: Tue, 9 Jun 2015 14:01:03 -0700 (PDT)
- Subject: Re: [PATCH] AArch64/ILP32: fix wrong sign extension in setgroups
- Authentication-results: sourceware.org; auth=none
- References: <mvmoal4kany dot fsf at hawking dot suse dot de> <20150605204008 dot A84822C39E3 at topped-with-meat dot com> <mvm8ubuk2dr dot fsf at hawking dot suse dot de>
> Roland McGrath <roland@hack.frob.com> writes:
>
> > But I don't quite understand why the new setgroups.c is required.
>
> It's required to avoid a warning about casting different sized types
> (pointer vs. __syscall_slong_t). I'll add a comment.
Perhaps just add the cast to the linux/setgroups.c implementation?
It's pretty much universal that INLINE_SYSCALL does not know anything
useful about the types of the arguments and casts them to a type like
__syscall_slong_t. We could make this a documented requirement for
using those macros.