This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PR18457] Don't require rtld lock to compute DTV addr for static TLS
- From: "Carlos O'Donell" <carlos at redhat dot com>
- To: Andreas Schwab <schwab at linux-m68k dot org>, Alexandre Oliva <aoliva at redhat dot com>
- Cc: Torvald Riegel <triegel at redhat dot com>, libc-alpha at sourceware dot org
- Date: Thu, 04 Jun 2015 12:41:43 -0400
- Subject: Re: [PR18457] Don't require rtld lock to compute DTV addr for static TLS
- Authentication-results: sourceware.org; auth=none
- References: <orvbf5ffyt dot fsf at livre dot home> <1433326788 dot 21461 dot 81 dot camel at triegel dot csb> <ora8whexn9 dot fsf at livre dot home> <m27frj8m70 dot fsf at linux-m68k dot org>
On 06/04/2015 12:36 PM, Andreas Schwab wrote:
> Alexandre Oliva <aoliva@redhat.com> writes:
>
>>>> +static int running = 1;
>>>> + while (running)
>>
>>> That's a data race with the modification do_end, or isn't it?
>
> There is no way this can go wrong.
That doesn't matter, it's still conceptually wrong and continues
to promote the idea that concurrency doesn't matter because the
hardware will just fix it (tm).
The whole point of writing data-race-free code is to get people
to think about concurrency and using the right constructs to
write concurrent code. That way when we have better tooling to
detect serious data races we don't have to fix all of these issues.
Cheers,
Carlos.