This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] fix BZ 18116 - build failure on ppc64le: setcontext.S uses power6 mtfsf when not supported
- From: "Tulio Magno Quites Machado Filho" <tuliom at linux dot vnet dot ibm dot com>
- To: Martin Sebor <msebor at redhat dot com>
- Cc: Steven Munroe <munroesj at linux dot vnet dot ibm dot com>, GNU C Library <libc-alpha at sourceware dot org>
- Cc:
- Date: Mon, 01 Jun 2015 16:23:45 -0300
- Subject: Re: [PATCH] fix BZ 18116 - build failure on ppc64le: setcontext.S uses power6 mtfsf when not supported
- Authentication-results: sourceware.org; auth=none
- References: <550715C8 dot 7020508 at redhat dot com> <1426538231 dot 13272 dot 28 dot camel at sjmunroe-ThinkPad-W500> <55074888 dot 5060408 at redhat dot com> <55076687 dot 7010903 at redhat dot com> <1426553899 dot 7010 dot 11 dot camel at oc8268013063 dot ibm dot com> <55079FC0 dot 3000806 at redhat dot com> <1426607756 dot 6715 dot 20 dot camel at sjmunroe-ThinkPad-W500> <5509AD48 dot 3070802 at redhat dot com> <1426857727 dot 6615 dot 5 dot camel at sjmunroe-ThinkPad-W500>
Steven Munroe <munroesj@linux.vnet.ibm.comcom> writes:
> On Wed, 2015-03-18 at 10:52 -0600, Martin Sebor wrote:
>> > I mean around each instance of mtfsf 0xff,fp0,1,0
>> >
>> > What you suggested is only correct and safe for IBM POWER hardware
>> > Power6 and later. It is not safe or correct for powerpc64 chips from
>> > other manufacturer that implement a subset of the PowerISA-2.05 (or
>> > later).
>>
>> I suspect you've misread the changes in the first patch.
>>
>> The first and the third patches are equivalent and after
>> preprocessing will result in the assembler seeing the
>> exact same code, including directives, regardless of what
>> the target cpu is.
>>
>
> The 3rd patch dated March 16th is good.
Committed as db8fed87d9741b6b3da6c2257f01d63ef2fe407c.
Thanks!
--
Tulio Magno