This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 1/14] [x86_64] Vector math functions (vector cos)
- From: Andrew Senkevich <andrew dot n dot senkevich at gmail dot com>
- To: Joseph Myers <joseph at codesourcery dot com>
- Cc: libc-alpha <libc-alpha at sourceware dot org>
- Date: Wed, 27 May 2015 13:40:48 +0300
- Subject: Re: [PATCH 1/14] [x86_64] Vector math functions (vector cos)
- Authentication-results: sourceware.org; auth=none
- References: <CAMXFM3t+v7zYEmvWQxV9aRmJB6Ag2hQgQ56cZJTDy=siRBszDw at mail dot gmail dot com> <alpine dot DEB dot 2 dot 10 dot 1504301541120 dot 23221 at digraph dot polyomino dot org dot uk> <CAMXFM3sVJ6vkEF7RqrrHczJSdF_-gr9Xog-zFcG3rjhOqgqjDw at mail dot gmail dot com> <alpine dot DEB dot 2 dot 10 dot 1505151616460 dot 21212 at digraph dot polyomino dot org dot uk> <CAMXFM3tfZKDJtjhJ1d=LQ=WALJBBx5ABJXoS5ycBORii78FkEg at mail dot gmail dot com> <alpine dot DEB dot 2 dot 10 dot 1505181711240 dot 20209 at digraph dot polyomino dot org dot uk> <CAMXFM3vG=5KVLuG4HJ6StDp13YcpeRLqPkd=3BJhGt1mu5AWPA at mail dot gmail dot com> <alpine dot DEB dot 2 dot 10 dot 1505201529070 dot 23246 at digraph dot polyomino dot org dot uk> <CAMXFM3u57e==ySd8TF7+qFwmrswcT1jqzcN-n_JDPF45+77Z0g at mail dot gmail dot com> <CAMXFM3uuDy3f2hb3Xg+MNmseqjmBFqUF1euRF_g5XW+wo7JSSQ at mail dot gmail dot com> <alpine dot DEB dot 2 dot 10 dot 1505221523570 dot 16611 at digraph dot polyomino dot org dot uk> <CAMXFM3sXNLR3_HPpkUBp_9Ue=-RYZYoidbCwP23Cp9HX_X+t5A at mail dot gmail dot com>
One inconsistency was found in this patch (in _ZGVdN4v_cos
implementation), here is diff for fix:
diff --git a/0001-x86-64-vector-cos.patch b/0001-x86-64-vector-cos.patch_fixed
index b6d29fe..62fbc2b 100755
--- a/0001-x86-64-vector-cos.patch
+++ b/0001-x86-64-vector-cos.patch_fixed
@@ -435,7 +435,7 @@ index 0000000..b1725f7
+ jne 1f
+ call __init_cpu_features
+1: leaq _ZGVdN4v_cos_avx2(%rip), %rax
-+ testl $bit_AVX2, __cpu_features+CPUID_OFFSET+index_AVX2(%rip)
++ testl $bit_AVX2_Usable,
__cpu_features+FEATURE_OFFSET+index_AVX2_Usable(%rip)
+ jz 2f
+ ret
+2: leaq _ZGVdN4v_cos_sse_wrapper(%rip), %rax
--
WBR,
Andrew