This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PROPOSED PATCH] Convert source files to UTF-8
- From: Roland McGrath <roland at hack dot frob dot com>
- To: Paul Eggert <eggert at cs dot ucla dot edu>
- Cc: libc-alpha at sourceware dot org
- Date: Fri, 22 May 2015 15:10:11 -0700 (PDT)
- Subject: Re: [PROPOSED PATCH] Convert source files to UTF-8
- Authentication-results: sourceware.org; auth=none
- References: <555FA4EB dot 1010401 at cs dot ucla dot edu>
Converting old ChangeLog files (or any other files not involved in the
build or install) is an "obvious enough". Just do that on its own and
commit it.
Then for further changes you can follow our protocol, which requires
including the ChangeLog entries in the message outside any patch or
attachment. That makes it reasonable to have a review thread at all
for a patch that has to be in an encoded attachment.
What I'd recommend for the first set of changes is replacing non-ASCII
literal bytes in strings with C escapes, and any conversions in comments
or string literals in any file. That's a change for which you can report
that you've verified the build products are completely unchanged before
and after the change. Then it needs barely any review, and can go in
very quickly.
Attack the other changes after those are in.
Thanks,
Roland