This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 1/14] [x86_64] Vector math functions (vector cos)
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Andrew Senkevich <andrew dot n dot senkevich at gmail dot com>
- Cc: libc-alpha <libc-alpha at sourceware dot org>
- Date: Fri, 22 May 2015 15:31:44 +0000
- Subject: Re: [PATCH 1/14] [x86_64] Vector math functions (vector cos)
- Authentication-results: sourceware.org; auth=none
- References: <CAMXFM3t+v7zYEmvWQxV9aRmJB6Ag2hQgQ56cZJTDy=siRBszDw at mail dot gmail dot com> <alpine dot DEB dot 2 dot 10 dot 1504301541120 dot 23221 at digraph dot polyomino dot org dot uk> <CAMXFM3sVJ6vkEF7RqrrHczJSdF_-gr9Xog-zFcG3rjhOqgqjDw at mail dot gmail dot com> <alpine dot DEB dot 2 dot 10 dot 1505151616460 dot 21212 at digraph dot polyomino dot org dot uk> <CAMXFM3tfZKDJtjhJ1d=LQ=WALJBBx5ABJXoS5ycBORii78FkEg at mail dot gmail dot com> <alpine dot DEB dot 2 dot 10 dot 1505181711240 dot 20209 at digraph dot polyomino dot org dot uk> <CAMXFM3vG=5KVLuG4HJ6StDp13YcpeRLqPkd=3BJhGt1mu5AWPA at mail dot gmail dot com> <alpine dot DEB dot 2 dot 10 dot 1505201529070 dot 23246 at digraph dot polyomino dot org dot uk> <CAMXFM3u57e==ySd8TF7+qFwmrswcT1jqzcN-n_JDPF45+77Z0g at mail dot gmail dot com> <CAMXFM3uuDy3f2hb3Xg+MNmseqjmBFqUF1euRF_g5XW+wo7JSSQ at mail dot gmail dot com>
On Thu, 21 May 2015, Andrew Senkevich wrote:
> diff --git a/sysdeps/x86_64/fpu/multiarch/Makefile b/sysdeps/x86_64/fpu/multiarch/Makefile
> index 12b0526..5ccf97b 100644
> --- a/sysdeps/x86_64/fpu/multiarch/Makefile
> +++ b/sysdeps/x86_64/fpu/multiarch/Makefile
> @@ -51,3 +51,7 @@ CFLAGS-slowexp-avx.c = -msse2avx -DSSE2AVX
> CFLAGS-s_tan-avx.c = -msse2avx -DSSE2AVX
> endif
> endif
> +
> +ifeq ($(subdir),mathvec)
> +libmvec-support += svml_d_cos2_core svml_d_cos8_core
> +endif
As far as I can tell, if you use --disable-multi-arch, then these files
won't be built into libmvec, and nothing else will provide the
_ZGVbN2v_cos and _ZGVeN8v_cos symbols. See other multiarch code for
examples of how such things are handled - typically, the file outside the
multiarch directory implements things for an always-supported architecture
variant (in this case, that would be a variant guaranteed to be supported
if the given entry point gets called), then, in the multiarch directory,
there are the implementations for other variants, and a file with the same
name as that outside the multiarch directory, that (a) provides the IFUNC
resolver and (b) defines some macros before #including the file in the
directory above, so that the basic version of the function gets defined
under a different name.
The elf/Makefile and include/libc-symbols.h changes are OK on their own -
I think it's best for them to go in now rather than together with the
first function implementations.
--
Joseph S. Myers
joseph@codesourcery.com