This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] nptl: Add missing err declaration __pthread_initialize_minimal_internal
- From: Florian Weimer <fweimer at redhat dot com>
- To: raj dot khem at gmail dot com
- Cc: libc-alpha at sourceware dot org
- Date: Fri, 22 May 2015 12:02:02 +0200
- Subject: Re: [PATCH] nptl: Add missing err declaration __pthread_initialize_minimal_internal
- Authentication-results: sourceware.org; auth=none
- References: <1432275814-4901-1-git-send-email-raj dot khem at gmail dot com>
On 05/22/2015 08:23 AM, Khem Raj wrote:
> Fixes build problems on mips
> nptl-init.c: In function '__pthread_initialize_minimal_internal':
> nptl-init.c:333:48: error: 'err' undeclared (first use in this function)
I think you should move the err definition closer to its users,
introducing a new scope if necessary. The use sites are conditional on
preprocessor symbols, and a function-global definition might result in
unused variable warnings on other architectures (which are treated as
errors).
--
Florian Weimer / Red Hat Product Security