This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH][BZ 18234] struct stat is not posix conform
- From: "Carlos O'Donell" <carlos at redhat dot com>
- To: Szabolcs Nagy <szabolcs dot nagy at arm dot com>, Siddhesh Poyarekar <siddhesh at redhat dot com>
- Cc: Joseph Myers <joseph at codesourcery dot com>, GNU C Library <libc-alpha at sourceware dot org>, Marcus Shawcroft <Marcus dot Shawcroft at arm dot com>, Ramana Radhakrishnan <Ramana dot Radhakrishnan at arm dot com>
- Date: Thu, 21 May 2015 14:00:58 -0400
- Subject: Re: [PATCH][BZ 18234] struct stat is not posix conform
- Authentication-results: sourceware.org; auth=none
- References: <555CA657 dot 2050300 at arm dot com> <555CB539 dot 4090208 at redhat dot com> <alpine dot DEB dot 2 dot 10 dot 1505201627430 dot 23246 at digraph dot polyomino dot org dot uk> <555CCA76 dot 2010605 at arm dot com> <20150521042934 dot GM15498 at spoyarek dot pnq dot redhat dot com> <555E04B0 dot 1020801 at arm dot com>
On 05/21/2015 12:15 PM, Szabolcs Nagy wrote:
> On 21/05/15 05:29, Siddhesh Poyarekar wrote:
>> On Wed, May 20, 2015 at 06:55:02PM +0100, Szabolcs Nagy wrote:
>>> i guess it's ok for consistency if i fix struct stat64
>>> too to use __USE_XOPEN2K8.
>>>
>>> i will run some tests and come back with a patch
>>
>> I also think it would be appropriate to change this code in other
>> architectures (microblaze and nacl IIRC) to make all of them
>> consistent. It is a mechanical enough change IMO that all arch
>> maintainer acks is not necessary.
>>
>
> here is the patch with consistent __USE_XOPEN2K8
>
> ok to commit?
>
> 2015-05-21 Szabolcs Nagy <szabolcs.nagy@arm.com>
>
> [BZ #18234]
> * conform/data/sys/stat.h-data (struct stat): Add tests for st_atim,
> st_mtim and st_ctim members.
>
> * sysdeps/nacl/bits/stat.h (struct stat, struct stat64): Make
> st_atim, st_ctim, st_mtim visible under __USE_XOPEN2K8 only.
>
> * sysdeps/unix/sysv/linux/generic/bits/stat.h (struct stat,):
> (struct stat64): Likewise.
>
> * sysdeps/unix/sysv/linux/ia64/bits/stat.h (struct stat,):
> (struct stat64): Likewise.
>
> * sysdeps/unix/sysv/linux/microblaze/bits/stat.h (struct stat,):
> (struct stat64): Likewise.
>
Modulo the ChangeLog problem pointed out by Siddhesh this also looks good to me.
Cheers,
Carlos.