This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Fix linknamespace test handling of architecture-specific st_other [committed]
- From: Joseph Myers <joseph at codesourcery dot com>
- To: <libc-alpha at sourceware dot org>
- Date: Tue, 12 May 2015 17:10:36 +0000
- Subject: Fix linknamespace test handling of architecture-specific st_other [committed]
- Authentication-results: sourceware.org; auth=none
For mips16, some of the linknamespace tests were failing because
[MIPS16] annotations in readelf output were wrongly interpreted as
falling in the symbol index field, meaning symbol index values were
wrongly interpreted as symbol names and such names as 1 and 2 then
resulted in namespace test failures.
This patch fixes this by removing the annotations for such
architecture-specific st_other bits before splitting the readelf
output into fields. Tested for x86_64 and mips16. Committed.
2015-05-12 Joseph Myers <joseph@codesourcery.com>
* conform/linknamespace.pl (list_syms): Remove \[.*?\] before
splitting into fields.
diff --git a/conform/linknamespace.pl b/conform/linknamespace.pl
index b534746..8ea437d 100644
--- a/conform/linknamespace.pl
+++ b/conform/linknamespace.pl
@@ -68,6 +68,9 @@ sub list_syms {
next;
}
s/^\s*//;
+ # Architecture-specific st_other bits appear inside [] and disrupt
+ # the format of readelf output.
+ s/\[.*?\]//;
my (@fields) = split (/\s+/, $_);
if (@fields < 8) {
next;
--
Joseph S. Myers
joseph@codesourcery.com