This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Do not build with -Winline
- From: Florian Weimer <fweimer at redhat dot com>
- To: Paul Eggert <eggert at cs dot ucla dot edu>, GNU C Library <libc-alpha at sourceware dot org>
- Date: Fri, 24 Apr 2015 17:08:57 +0200
- Subject: Re: [PATCH] Do not build with -Winline
- Authentication-results: sourceware.org; auth=none
- References: <553A08BE dot 4040700 at redhat dot com> <553A5ABB dot 50303 at cs dot ucla dot edu>
On 04/24/2015 05:01 PM, Paul Eggert wrote:
> Florian Weimer wrote:
>> Per the previous discussion.
>
> This patch looks good to me. In other GNU projects we've found that
> -Winline is more trouble than it's worth. Like
> -Wunsafe-loop-optimizations, all that -Winline tells you is that
> generated code is not quite as efficient as it might be under ideal
> conditions, which is not a big deal, certainly not worth breaking a
> build over.
Thanks, committed.
It's even worse, -Winline warns for cases where the code is, in fact,
optimal (not inlining a non-trivial function called multiple times from
unlikely code is often beneficial).
--
Florian Weimer / Red Hat Product Security