This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: x86: Fix x32 syscall build


On Wed, Apr 22, 2015 at 1:21 PM, Adhemerval Zanella
<adhemerval.zanella@linaro.org> wrote:
> Working on the vDSO refactor I noted that x86_64/x32 build is broken
> due some vdso declaration in syscall.list that is shadowing the
> default x86 implementation.  This patch fixes it by removing the
> auto syscall generation and make x32 uses the default Linux x86
> code.
>
> Tested on x32, ok to commit?
>
> --
>
>         * sysdeps/unix/sysv/linux/x86_64/x32/syscalls.list (gettimeofday):
>         Remove definition.
>         (time): Likewise.
>
> ---
>
> diff --git a/sysdeps/unix/sysv/linux/x86_64/x32/syscalls.list b/sysdeps/unix/sysv/linux/x86_64/x32/syscalls.list
> index 2cc58af..7edb6fd 100644
> --- a/sysdeps/unix/sysv/linux/x86_64/x32/syscalls.list
> +++ b/sysdeps/unix/sysv/linux/x86_64/x32/syscalls.list
> @@ -1,8 +1,6 @@
>  # File name    Caller  Syscall name    # args  Strong name     Weak names
>
>  fallocate      -       fallocate       Ci:iiii fallocate       fallocate64
> -gettimeofday   -       gettimeofday:__vdso_gettimeofday@LINUX_2.6      i:pP    __gettimeofday  gettimeofday
>  posix_fadvise  -       fadvise64       Vi:iiii posix_fadvise   posix_fadvise64
>  preadv         -       preadv          Ci:ipii preadv          preadv64
>  pwritev                -       pwritev         Ci:ipii pwritev         pwritev64
> -time           -       time:__vdso_time@LINUX_2.6                      Ei:P    time

X32 builds fine for me without the above change.  Why did it fail for you?

-- 
H.J.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]