This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PING][PATCH] [BZ #17596] mblen return code when n is zero
- From: "H.J. Lu" <hjl dot tools at gmail dot com>
- To: Stefan Liebler <stli at linux dot vnet dot ibm dot com>
- Cc: GNU C Library <libc-alpha at sourceware dot org>
- Date: Fri, 10 Apr 2015 15:46:17 -0700
- Subject: Re: [PING][PATCH] [BZ #17596] mblen return code when n is zero
- Authentication-results: sourceware.org; auth=none
- References: <1415890908-50691-1-git-send-email-raji at linux dot vnet dot ibm dot com> <mvmk32z3y5l dot fsf at hawking dot suse dot de> <5464D746 dot 2030300 at cs dot ucla dot edu> <5465A7FC dot 4080701 at linux dot vnet dot ibm dot com> <20141127170625 dot GA13805 at domone> <20150306103646 dot GW12857 at vapier> <20150403134913 dot GA22649 at domone> <mg0p07$nrk$1 at ger dot gmane dot org>
On Tue, Apr 7, 2015 at 7:18 AM, Stefan Liebler <stli@linux.vnet.ibm.com> wrote:
> Hi,
>
> the test localedata/tst_mbrlen fails with:
> mbrlen:de_DE.ISO-8859-1:1:1:2:F:the return value is different from an
> expected value
> mbrlen:de_DE.ISO-8859-1:1:2:2:S:PASSED
> mbrlen:de_DE.ISO-8859-1:1:3:2:S:PASSED
> mbrlen:de_DE.ISO-8859-1:2:1:2:F:the return value is different from an
> expected value
> mbrlen:de_DE.ISO-8859-1:2:2:2:S:PASSED
> mbrlen:de_DE.ISO-8859-1:2:3:2:S:PASSED
> mbrlen:en_US.ANSI_X3.4-1968:1:1:2:F:the return value is different from an
> expected value
> mbrlen:en_US.ANSI_X3.4-1968:1:2:2:S:PASSED
> mbrlen:en_US.ANSI_X3.4-1968:1:3:2:S:PASSED
> mbrlen:en_US.ANSI_X3.4-1968:2:1:2:F:the return value is different from an
> expected value
> mbrlen:en_US.ANSI_X3.4-1968:2:2:1:S:PASSED
> mbrlen:en_US.ANSI_X3.4-1968:2:2:2:S:PASSED
> mbrlen:en_US.ANSI_X3.4-1968:2:3:1:S:PASSED
> mbrlen:en_US.ANSI_X3.4-1968:2:3:2:S:PASSED
> mbrlen:ja_JP.EUC-JP:1:1:2:S:PASSED
> mbrlen:ja_JP.EUC-JP:1:2:2:S:PASSED
> mbrlen:ja_JP.EUC-JP:1:3:2:S:PASSED
> mbrlen:ja_JP.EUC-JP:2:1:2:S:PASSED
> mbrlen:ja_JP.EUC-JP:2:2:2:S:PASSED
> mbrlen:ja_JP.EUC-JP:2:3:2:S:PASSED
> mbrlen:ja_JP.EUC-JP:3:1:2:F:the return value is different from an expected
> value
> mbrlen:ja_JP.EUC-JP:3:2:2:S:PASSED
> mbrlen:ja_JP.EUC-JP:3:3:1:S:PASSED
> mbrlen:ja_JP.EUC-JP:3:3:2:S:PASSED
>
> and test localedata/tst_mbrtowc fails with:
> mbrtowc:de_DE.ISO-8859-1:1:1:3:F:Initialization failed - skipping this test
> case.
> mbrtowc:de_DE.ISO-8859-1:2:1:3:F:Initialization failed - skipping this test
> case.
>
> This patch change the expected results for mbrlen in case of passing n=0 to
> -2. The initialization of tst_mbrtowc is changed in the same way.
>
> Tested on s390/s390x.
>
> Please commit.
>
> Bye Stefan
>
> ---
> 2015-04-07 Stefan Liebler <stli@linux.vnet.ibm.com>
>
> localedata/tests-mbwc/dat_mbrlen.c
> (tst_mbrlen_loc): Change expected result to -2
> in case of n == 0.
> localedata/tests-mbwc/tst_mbrtowc.c (tst_mbrtowc):
> Check result against -2 instead of 0.
>
Pushed. Thanks.
--
H.J.