Re: [PATCH][BZ #6792] Set errno for log1p on pole/domain error.

[Stefan Liebler <stli at linux dot vnet dot ibm dot com>]

On 04/07/2015 07:13 PM, Joseph Myers wrote:
> On Tue, 31 Mar 2015, Stefan Liebler wrote:
>
> > 2015-03-31  Stefan Liebler  <stli@linux.vnet.ibm.com>
> >
> > 	[BZ #6792]
> > 	math/w_log1p.c: New File.
> > 	Add wrapper which sets errno on pole or domain error.
> > 	Add weak_alias for corresponding log1p function.
>
> All these ChangeLog entries are missing the initial '* ' before the file
> name.  "New file" not "New File".  No further description of the file is
> needed in the ChangeLog entry.
>
> > 	math/s_log1pl.c:
> > 	Remove weak_alias for corresponding log1p function.
>
> 	(log1pl): Remove weak_alias.
>
> > +    TEST_f_f (log1p, -2, qnan_value, INVALID_EXCEPTION|EDOM),
>
> ERRNO_EDOM, not just EDOM.
>
> > +/* Wrapper for __log1p handles setting errno.
>
> "that handles".
>
> > +double
> > +__w_log1p (double x)
> > +{
> > +  if (__glibc_unlikely (x <= -1.0))
>
> I'd expect you to need islessequal here to avoid spurious "invalid"
> exceptions for quiet NaN arguments.  (Some architectures may have GCC bugs
> meaning the wrong comparison gets used for <= and so this doesn't show up
> in glibc testing, e.g. bug 58684 for powerpc, but using <= would result in
> failures for architectures without such bugs or where those GCC bugs don't
> apply when compiling this implementation.)
>
> The same comments apply to the implementations for other types.
>
> > +/* Nothing to do.
> > +   Errno is set in sysdeps/ia64/fpu/s_log1pf.S.  */
>
> See the GNU Coding Standards: "If a lower-case identifier comes at the
> beginning of a sentence, don't capitalize it!  Changing the spelling makes
> it a different identifier.".

okay. thanks.
This is the adjusted patch with the correct changelog.
Is this ok?

Bye

---
2015-04-08  Stefan Liebler  <stli@linux.vnet.ibm.com>

	[BZ #6792]
	* math/w_log1p.c: New file.
	* math/w_log1pf.c: Likewise.
	* math/w_log1pl.c: Likewise.
	* math/Makefile (libm-calls): Add w_log1p.
	* math/s_log1pl.c (log1pl): Remove weak_alias.
	* sysdeps/i386/fpu/s_log1p.S (log1p): Likewise.
	* sysdeps/i386/fpu/s_log1pf.S (log1pf): Likewise.
	* sysdeps/i386/fpu/s_log1pl.S (log1pl): Likewise.
	* sysdeps/x86_64/fpu/s_log1pl.S (log1pl): Likewise.
	* sysdeps/ieee754/dbl-64/s_log1p.c (log1p): Likewise.
	[NO_LONG_DOUBLE] (log1pl): Likewise.
	* sysdeps/ieee754/flt-32/s_log1pf.c (log1pf): Likewise.
	* sysdeps/ieee754/ldbl-128/s_log1pl.c (log1pl): Likewise.
	* sysdeps/ieee754/ldbl-64-128/s_log1pl.c
	(log1p): Remove long_double_symbol.
	* sysdeps/ieee754/ldbl-128ibm/s_log1pl.c (log1pl): Likewise.
	* sysdeps/ieee754/ldbl-64-128/w_log1pl.c: New file.
	* sysdeps/ieee754/ldbl-128ibm/w_log1pl.c: Likewise.
	* sysdeps/m68k/m680x0/fpu/s_log1p.c: Define empty weak_alias to
	remove weak_alias for corresponding log1p function.
	* sysdeps/m68k/m680x0/fpu/s_log1pf.c: Likewise.
	* sysdeps/m68k/m680x0/fpu/s_log1pl.c: Likewise.
	* sysdeps/ia64/fpu/w_log1p.c: New file.
	* sysdeps/ia64/fpu/w_log1pf.c: Likewise.
	* sysdeps/ia64/fpu/w_log1pl.c: Likewise.
	* math/libm-test.inc (log1p_test_data):	Add errno expectations.

Attachment: log1p_08042015
Description: Text document