This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
[PATCH] NPTL: Fix wrong comments for THREAD_SETMEM and THREAD_SETMEM_NC for i386 and x86_64.
- From: Martin Galvan <martin dot galvan at tallertechnologies dot com>
- To: libc-alpha at sourceware dot org
- Date: Sat, 28 Mar 2015 01:31:56 -0300
- Subject: [PATCH] NPTL: Fix wrong comments for THREAD_SETMEM and THREAD_SETMEM_NC for i386 and x86_64.
- Authentication-results: sourceware.org; auth=none
2015-03-28 Martin Galvan <martin.galvan@tallertechnologies.com>
The comments for THREAD_SETMEM and THREAD_SETMEM_NC were swapped for i386 and x86_64; this patch fixes that.
I don't have a copyright assignment yet, but since this is a minor change I don't think it's necessary.
ChangeLog:
* sysdeps/i386/nptl/tls.h: Swapped comments between THREAD_SETMEM and
THREAD_SETMEM_NC.
* sysdeps/x86_64/nptl/tls.h: Ditto.
---
sysdeps/i386/nptl/tls.h | 5 +++--
sysdeps/x86_64/nptl/tls.h | 4 ++--
2 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/sysdeps/i386/nptl/tls.h b/sysdeps/i386/nptl/tls.h
index 40f84ef..829cd3a 100644
--- a/sysdeps/i386/nptl/tls.h
+++ b/sysdeps/i386/nptl/tls.h
@@ -316,7 +316,8 @@ tls_fill_user_desc (union user_desc_init *desc,
__value; })
-/* Same as THREAD_SETMEM, but the member offset can be non-constant. */
+
+/* Set member of the thread descriptor directly. */
# define THREAD_SETMEM(descr, member, value) \
({ if (sizeof (descr->member) == 1) \
asm volatile ("movb %b0,%%gs:%P1" : \
@@ -341,7 +342,7 @@ tls_fill_user_desc (union user_desc_init *desc,
}})
-/* Set member of the thread descriptor directly. */
+/* Same as THREAD_SETMEM, but the member offset can be non-constant. */
# define THREAD_SETMEM_NC(descr, member, idx, value) \
({ if (sizeof (descr->member[0]) == 1) \
asm volatile ("movb %b0,%%gs:%P1(%2)" : \
diff --git a/sysdeps/x86_64/nptl/tls.h b/sysdeps/x86_64/nptl/tls.h
index b947d57..d7543c6 100644
--- a/sysdeps/x86_64/nptl/tls.h
+++ b/sysdeps/x86_64/nptl/tls.h
@@ -250,7 +250,7 @@ typedef struct
#endif
-/* Same as THREAD_SETMEM, but the member offset can be non-constant. */
+/* Set member of the thread descriptor directly. */
# define THREAD_SETMEM(descr, member, value) \
({ if (sizeof (descr->member) == 1) \
asm volatile ("movb %b0,%%fs:%P1" : \
@@ -273,7 +273,7 @@ typedef struct
}})
-/* Set member of the thread descriptor directly. */
+/* Same as THREAD_SETMEM, but the member offset can be non-constant. */
# define THREAD_SETMEM_NC(descr, member, idx, value) \
({ if (sizeof (descr->member[0]) == 1) \
asm volatile ("movb %b0,%%fs:%P1(%q2)" : \
--
2.3.4