This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 06/25] Add struct scratch_buffer and its internal helper functions

From: Paul Eggert <eggert at cs dot ucla dot edu>
To: Florian Weimer <fweimer at redhat dot com>, libc-alpha at sourceware dot org
Date: Mon, 23 Mar 2015 10:41:47 -0700
Subject: Re: [PATCH 06/25] Add struct scratch_buffer and its internal helper functions
Authentication-results: sourceware.org; auth=none
References: <cover dot 1425285061 dot git dot fweimer at redhat dot com> <7a6fe503fb764beee3d5b89662d3bbf65242161c dot 1425285061 dot git dot fweimer at redhat dot com> <54F4BB15 dot 7070409 at cs dot ucla dot edu> <550C37F7 dot 10504 at redhat dot com> <550C4AE0 dot 60205 at cs dot ucla dot edu> <55103BEA dot 7070305 at redhat dot com>

Florian Weimer wrote:

I would rather go with intmax_t because it's not
clear to me if __alignof__ (max_align_t) increases to 64 if AVX-512 is
enabled on x86_64.


That would be a bug in the C compiler, right?

Since C allows platforms where pointers and/or floating-point values havealignments stricter than intmax_t, I suggest using 'max (__alignof__ (intmax_t),__alignof__ (max_align_t))' along with a comment explaining why you don't trustmax_align_t here.

Follow-Ups:
- Re: [PATCH 06/25] Add struct scratch_buffer and its internal helper functions
  - From: Joseph Myers

References:
- [PATCH 00/25] Remove extend_alloca [BZ #18023]
  - From: Florian Weimer
- [PATCH 06/25] Add struct scratch_buffer and its internal helper functions
  - From: Florian Weimer
- Re: [PATCH 06/25] Add struct scratch_buffer and its internal helper functions
  - From: Paul Eggert
- Re: [PATCH 06/25] Add struct scratch_buffer and its internal helper functions
  - From: Florian Weimer
- Re: [PATCH 06/25] Add struct scratch_buffer and its internal helper functions
  - From: Paul Eggert
- Re: [PATCH 06/25] Add struct scratch_buffer and its internal helper functions
  - From: Florian Weimer

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]