This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [COMMITTED PATCH] Move tilegx, tilepro, and linux-generic from ports to libc.


On Thu, Mar 19, 2015 at 10:12 AM, Chris Metcalf <cmetcalf@ezchip.com> wrote:
> On 03/19/2015 01:04 PM, H.J. Lu wrote:
>>>>
>>>> Having both
>>>> >>
>>>> >>sysdeps/unix/sysv/linux/generic/bits/statfs.h
>>>> >>
>>>> >>and
>>>> >>
>>>> >>sysdeps/unix/sysv/linux/bits/statfs.h
>>>> >>
>>>> >>is very strange.
>>>
>>> >
>>> >
>>> >Yes, I don't love the naming either, but no one could come up with
>>> > anything
>>> >better when this was initially introduced.
>>> >
>>
>> How about sysdeps/unix/sysv/linux/asm-generic/bits/statfs.h?
>
>
> As I recall the original discussion, the idea was that going forward the
> asm-generic stuff would correspond to new "generic" Linux support.  It's not
> clear the "asm-" really adds anything to the name.
>
> That said, I don't feel strongly about it, and if there is consensus to
> change the name, I'd be happy to accept a patch to do so.  There are 80+
> files in that hierarchy, but I think some simple grep work should suffice to
> find any references to linux/generic.
>

There are many files in linux/generic.  I don't know if it is worth
to change.  It is just very annoying.  Is the linux/generic scheme
documented in glibc tree?  Should there be a README in
linux/generic directory?


-- 
H.J.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]