This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [COMMITTED PATCH] Move tilegx, tilepro, and linux-generic from ports to libc.
- From: Szabolcs Nagy <szabolcs dot nagy at arm dot com>
- To: "H.J. Lu" <hjl dot tools at gmail dot com>, Chris Metcalf <cmetcalf at tilera dot com>
- Cc: GNU C Library <libc-alpha at sourceware dot org>
- Date: Thu, 19 Mar 2015 10:09:21 +0000
- Subject: Re: [COMMITTED PATCH] Move tilegx, tilepro, and linux-generic from ports to libc.
- Authentication-results: sourceware.org; auth=none
- References: <201402101603 dot s1AG30C9000514 at gx-1 dot internal dot tilera dot com> <CAMe9rOpqM3QsZpFnCb57gcWMwFR6acdVCvofV=U40avD78nG8w at mail dot gmail dot com>
On 18/03/15 11:59, H.J. Lu wrote:
> Any particular reason to add
>
> sysdeps/unix/sysv/linux/generic/bits/statfs.h
>
> when there is
>
> sysdeps/unix/sysv/linux/bits/statfs.h
>
> already? Why can't it be used? Here is a patch to remove it. OK
> for master?
>
the two does not seem to be the same on 32bit archs when 32bit
off_t is used
the first tries to use a layout that is compatible with the
64bit off_t version (so it needs endianness dependent padding)
the second uses the legacy syscall for 32bit off_t mode which
has no paddings
i'm not an expert in the legacy 32bit off_t hacks, but if you
remove the first then all the related functions from
sysdeps/unix/sysv/linux/generic/wordsize-32/*
(which do 32bit vs 64bit overflow checks etc)