This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] 'yes' within the path sets wrong config variables
- From: Benjamin Esquivel <benjamin dot esquivel at linux dot intel dot com>
- To: Mike Frysinger <vapier at gentoo dot org>
- Cc: Joseph Myers <joseph at codesourcery dot com>, libc-alpha at sourceware dot org
- Date: Wed, 04 Mar 2015 10:04:12 -0600
- Subject: Re: [PATCH] 'yes' within the path sets wrong config variables
- Authentication-results: sourceware.org; auth=none
- References: <1425394379-41448-1-git-send-email-benjamin dot esquivel at linux dot intel dot com> <alpine dot DEB dot 2 dot 10 dot 1503040357100 dot 9290 at digraph dot polyomino dot org dot uk> <20150304060037 dot GC6185 at vapier>
- Reply-to: benjamin dot esquivel at linux dot intel dot com
On Wed, 2015-03-04 at 01:00 -0500, Mike Frysinger wrote:
> On 04 Mar 2015 03:58, Joseph Myers wrote:
> > On Tue, 3 Mar 2015, Benjamin Esquivel wrote:
> > > It seems that the 'AC_EGREP_CPP(yes...' example is quite popular
> > > but being such a short word to grep it is likely to produce
> > > false-positive matches with the path it is configured into.
> >
> > What's your objection to the AC_PREPROC_IFELSE / #error approach suggested
> > in <https://sourceware.org/ml/libc-alpha/2014-08/msg00414.html>?
>
I don't have an objection to either approaches. Semantically, it looks
to me that AC_CHECK_DEFINE is a better option. I'll give it a try.
> that would be an improvement over the status quo, but i think AC_CHECK_DEFINE is
> even better
> -mike