This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 02/25] pthread_setaffinity (Linux variant): Rewrite to use VLA instead of alloca

From: Mike Frysinger <vapier at gentoo dot org>
To: Florian Weimer <fweimer at redhat dot com>
Cc: libc-alpha at sourceware dot org
Date: Mon, 2 Mar 2015 14:58:44 -0500
Subject: Re: [PATCH 02/25] pthread_setaffinity (Linux variant): Rewrite to use VLA instead of alloca
Authentication-results: sourceware.org; auth=none
References: <cover dot 1425285061 dot git dot fweimer at redhat dot com> <080236bd5f23d9be4c47794ad23e96d52d380f5d dot 1425285061 dot git dot fweimer at redhat dot com>

On 01 Mar 2015 15:05, Florian Weimer wrote:
> extend_alloca was used to emulate VLA deallocation.

general note: i found the old code easier to read.  i think GNU style requires 
newlines after decls and before the return statement.  that would certainly help  
readability here.
-mike

Attachment: signature.asc
Description: Digital signature

Follow-Ups:
- Re: [PATCH 02/25] pthread_setaffinity (Linux variant): Rewrite to use VLA instead of alloca
  - From: Florian Weimer

References:
- [PATCH 00/25] Remove extend_alloca [BZ #18023]
  - From: Florian Weimer
- [PATCH 02/25] pthread_setaffinity (Linux variant): Rewrite to use VLA instead of alloca
  - From: Florian Weimer

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]