This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
RE: [PATCH] Fix dynamic linker issue with bind-now
- From: "Petar Jovanovic" <petar dot jovanovic at rt-rk dot com>
- To: "'Mike Frysinger'" <vapier at gentoo dot org>
- Cc: <libc-alpha at sourceware dot org>, <petar dot jovanovic at imgtec dot com>
- Date: Mon, 2 Mar 2015 17:19:59 +0100
- Subject: RE: [PATCH] Fix dynamic linker issue with bind-now
- Authentication-results: sourceware.org; auth=none
- References: <1408493406-86741-1-git-send-email-petar dot jovanovic at rt-rk dot com> <1408493406-86741-2-git-send-email-petar dot jovanovic at rt-rk dot com> <000a01cfe8dd$488fbdf0$d9af39d0$ at rt-rk dot com> <20141021213320 dot GA25185 at vapier> <000301d00e87$8284f5f0$878ee1d0$ at rt-rk dot com> <CANu=DmjNC0iFRcHiifhgb0x5ot1t1gCOEktKpq9irt+j_A-5_Q at mail dot gmail dot com> <002a01d010ee$3115af70$93410e50$ at rt-rk dot com> <m2fvct6rui dot fsf at linux-m68k dot org> <000201d011b9$a9e6edd0$fdb4c970$ at rt-rk dot com> <20150302062928 dot GX19363 at vapier>
-----Original Message-----
From: Mike Frysinger [mailto:vapier@gentoo.org]
Sent: Monday, March 2, 2015 7:29 AM
To: Petar Jovanovic
Cc: libc-alpha@sourceware.org; petar.jovanovic@imgtec.com
Subject: Re: [PATCH] Fix dynamic linker issue with bind-now
>shouldn't the source file be compiled w/-fPIE too ?
In the new version of the patch, this has been changed, so no CFLAGS are
required.
> do you need the IS_IN_build define ? i'm not seeing it used.
It was required for the use of "-O0". Now it is not needed anymore in v3.
>> +tst-split-dynreloc-ENV = LD_BIND_NOW=1
>do you need to use the env var ? pass -Wl,-z,now via LDFLAGS instead ?
Done.
> this should be at the top of the file -- move the includes/globals/etc... below
Done.
> +int
> +main (void)
> +{
> + printf ("%s\n", foo);
> + return 0;
> +}
> please use test-skeleton.c. look at time/tst-ftime.c as a simple example.
Done.
Take a look at v3 of the change. Thanks.
Regards,
Petar