This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] [BZ 17542] sunrpc: conditional jump depends on uninitialised value in svc_getreq_common

From: Siddhesh Poyarekar <siddhesh at redhat dot com>
To: Andreas Schwab <schwab at suse dot de>
Cc: Brad Hubbard <bhubbard at redhat dot com>, OndÅej BÃlka <neleai at seznam dot cz>, libc-alpha at sourceware dot org
Date: Mon, 2 Mar 2015 14:42:58 +0530
Subject: Re: [PATCH] [BZ 17542] sunrpc: conditional jump depends on uninitialised value in svc_getreq_common
Authentication-results: sourceware.org; auth=none
References: <54597868 dot 3060408 at redhat dot com> <mvmr3xif28d dot fsf at hawking dot suse dot de> <20141105091434 dot GJ17703 at spoyarek dot pnq dot redhat dot com> <20141209223328 dot GA4523 at domone> <54877C34 dot 8040007 at redhat dot com> <20141210073828 dot GZ19849 at spoyarek dot pnq dot redhat dot com> <mvm8uifx64t dot fsf at hawking dot suse dot de> <20141210083645 dot GA19849 at spoyarek dot pnq dot redhat dot com>

On Wed, Dec 10, 2014 at 02:06:45PM +0530, Siddhesh Poyarekar wrote:
> On Wed, Dec 10, 2014 at 09:26:26AM +0100, Andreas Schwab wrote:
> > We should first understand what is the real bug.
> 
> The real bug is in the calling application, which calls svc_getreq on
> a file descriptor that it did not register.  We're patching this in
> sunrpc so that the check in svc_getreq_common below that was supposed
> to catch such conditions actually works.
> 
> ...
>   xprt = xports[fd];
>   /* Do we control fd? */
>   if (xprt == NULL)
>      return;
> ...

Andreas, is this OK or are you still not convinced about adding this
patch in?

Siddhesh

Attachment: pgp65pl1BDrx_.pgp
Description: PGP signature

Follow-Ups:
- Re: [PATCH] [BZ 17542] sunrpc: conditional jump depends on uninitialised value in svc_getreq_common
  - From: Andreas Schwab

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]