This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Adjust some timeouts for slow CPUs


On 2015/2/20 01:44 AM, Carlos O'Donell wrote:
> On 02/03/2015 01:33 PM, Carlos O'Donell wrote:
>> On 02/02/2015 08:37 PM, Chung-Lin Tang wrote:
>>> Ping?
>>>
>>> On 2015/1/24 02:10 PM, Chung-Lin Tang wrote:
>>>> Hi, this was submitted earlier with the nios2 patches, but Joseph
>>>> suggested it to be a separate patch.
>>>>
>>>> Some tests take a really long time to run on slow CPUs, often with no
>>>> FPU, like typical Nios II soft-cores; I noticed a few tests started to
>>>> timeout after they were updated to use test-skeleton.c.
>>>>
>>>> So I'm seeking permission to adjust the timeouts as attached.  This
>>>> won't unstabilize anything, okay to commit?
>>>>
>>>> Thanks,
>>>> Chung-Lin
>>>>
>>>> 2015-01-24  Chung-Lin Tang  <cltang@codesourcery.com>
>>>>
>>>>         * libio/tst-memstream2.c (TIMEOUT): Define as 100.
>>>>         * math/atest-exp.c (TIMEOUT): Adjust to 200.
>>>>         * math/atest-exp2.c (TIMEOUT): Adjust to 300.
>>>>         * math/atest-sincos.c (TIMEOUT): Adjust to 600.
>>>>
>>>
>>
>> OK, for 2.22 when it opens.
>>
>> All of our tests should work consistently for all of our supported
>> machines, and now that Nios II is checked in, this patch has a reason
>> to exist.
>>
>> I'm sure you know, but just to reiterate, you could use TIMEOUTFACTOR
>> env-var to work around this, but it's always good to make this work
>> out of the box.
> 
> 2.22 is open and this is ACK'd.
> 
> Please check this in.
> 
> Cheers,
> Carlos.

Done.

Thanks,
Chung-Lin




Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]