Re: [PATCH] Silence resolver logging for DNAME records when DNSSEC is enabled

[Siddhesh Poyarekar <siddhesh at redhat dot com>]

On Fri, Feb 20, 2015 at 02:54:18PM +0100, Florian Weimer wrote:
> You are inconsistent about the space after p_class and p_type.

You mean between gethnamaddr.c and dns-host.c?  I left that untouched
because the gethnamaddr uses a completely different code formatting,
likely from the bind source.

> I noticed there is an existing bug in p_type which affects the code:
> 
>   <https://sourceware.org/bugzilla/show_bug.cgi?id=18004>
> 
> Your patch looks fine, but I suggest to be more explicit the comment,
> saying that DNSSEC uses many different types in responses which do not
> match the QTYPE.

Ack, I'll expand the comment.  I'll wait for more comments and commit
it on Tuesday since my Monday comes earlier than most people here.

Siddhesh

Attachment: pgp5g4dzIuosd.pgp
Description: PGP signature