This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v3 1/4] Nios II port re-submission, sysdeps/nios2


On Sat, 10 Jan 2015, Chung-Lin Tang wrote:

>         * sysdeps/nios2/soft-fp/sfp-machine.h: New file.

As Roland noted in 
<https://sourceware.org/ml/libc-alpha/2014-10/msg00369.html>, soft-fp 
subdirectories that are always used are redundant - the files in them can 
be moved one level up, and the entries in Implies removed.

Some new files have the copyright notice as their first line.  The first 
line should be a description of the file (like you have in 
sysdeps/nios2/bits/setjmp.h, for example), with the copyright notice as 
the next line.

> diff --git a/sysdeps/nios2/Versions b/sysdeps/nios2/Versions
> new file mode 100644
> index 0000000..fd0110e
> --- /dev/null
> +++ b/sysdeps/nios2/Versions
> @@ -0,0 +1,12 @@
> +libc {
> +  GLIBC_2.20 {
> +    __adddf3; __addsf3; __divdf3; __divsf3; __eqdf2; __eqsf2; __extendsfdf2;
> +    __fixdfdi; __fixdfsi; __fixsfdi; __fixsfsi;
> +    __fixunsdfdi; __fixunsdfsi; __fixunssfdi; __fixunssfsi;
> +    __floatdidf; __floatdisf; __floatsidf; __floatsisf;
> +    __floatundidf; __floatundisf; __floatunsidf; __floatunsisf;
> +    __gedf2; __gesf2; __gtdf2; __gtsf2; __ledf2; __lesf2; __ltdf2; __ltsf2;
> +    __muldf3; __mulsf3; __nedf2; __nesf2; __negdf2; __negsf2;
> +    __subdf3; __subsf3; __truncdfsf2; __unorddf2; __unordsf2;
> +  }
> +}

Should be GLIBC_2.21 (it's least confusing for Versions entries used only 
on one system to reflect the actual symbol versions on that system, even 
though references to older versions should get automatically adjusted when 
glibc is built).

> +/* XXX Until we have a better place keep the definitions here.  */
> +#define __exit_thread_inline(val) \
> +  INLINE_SYSCALL (exit, 1, (val))

This was removed from pthreaddef.h on 2014-05-13.  Watch out for any other 
such global changes for which there should be port updates....

-- 
Joseph S. Myers
joseph@codesourcery.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]