This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[COMITTTED] iconvdata/run-iconv-test.sh: Actually test iconv modules


Arjun Shankar noticed that this test case was not testing anything because iconv was invoked without the required arguments.

2014-12-23  Florian Weimer  <fweimer@redhat.com>

	* iconvdata/run-iconv-test.sh: Actually test iconv modules.

--
Florian Weimer / Red Hat Product Security
diff --git a/iconvdata/run-iconv-test.sh b/iconvdata/run-iconv-test.sh
index 5dfb69f..1d0bf52 100755
--- a/iconvdata/run-iconv-test.sh
+++ b/iconvdata/run-iconv-test.sh
@@ -189,7 +189,7 @@ printf '\016\377\377\377\377\377\377\377' > $temp1
 for from in $iconv_modules ; do
     echo $ac_n "test decoder $from $ac_c"
     PROG=`eval echo $ICONV`
-    if $PROG < $temp1 >/dev/null 2>&1 ; then
+    if $PROG -f $from -t UTF8 < $temp1 >/dev/null 2>&1 ; then
 	: # fall through
     else
 	status=$?

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]