This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [Patch, MIPS] Modify dl-machine.h for mips32r6/mips64r6
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Steve Ellcey <sellcey at imgtec dot com>
- Cc: <libc-alpha at sourceware dot org>
- Date: Fri, 19 Dec 2014 21:51:45 +0000
- Subject: Re: [Patch, MIPS] Modify dl-machine.h for mips32r6/mips64r6
- Authentication-results: sourceware.org; auth=none
- References: <67afeb7f-c91f-4702-bf3e-97d9d22bd9b7 at BAMAIL02 dot ba dot imgtec dot org>
On Fri, 19 Dec 2014, Steve Ellcey wrote:
> @@ -138,7 +138,11 @@ elf_machine_load_address (void)
> #ifndef __mips16
> asm (" .set noreorder\n"
> " " STRINGXP (PTR_LA) " %0, 0f\n"
> +#if __mips_isa_rev < 6
> " bltzal $0, 0f\n"
> +#else
> + " bal 0f\n"
> +#endif
Correct preprocessor indentation, since inside #ifndef __mips16, i.e. a
single space between "#" and if/else/endif.
> @@ -241,6 +245,11 @@ do { \
> and not just plain _start. */
>
> #ifndef __mips16
> +#if __mips_isa_rev < 6
> +#define LOAD_31 STRINGXP(bltzal $8) "," STRINGXP(.Lcoff)
> +#else
> +#define LOAD_31 STRINGXP(bal .Lcoff)
> +#endif
Likewise (one space before if/else/endif, two before define).
OK with that change.
--
Joseph S. Myers
joseph@codesourcery.com