This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] powerpc: Fix unitialized variable
- From: Stefan Liebler <stli at linux dot vnet dot ibm dot com>
- To: libc-alpha at sourceware dot org
- Date: Thu, 11 Dec 2014 17:27:53 +0100
- Subject: Re: [PATCH] powerpc: Fix unitialized variable
- Authentication-results: sourceware.org; auth=none
- References: <54889AAC dot 3060404 at linux dot vnet dot ibm dot com> <alpine dot DEB dot 2 dot 10 dot 1412102119230 dot 26602 at digraph dot polyomino dot org dot uk> <5488DA58 dot 9010505 at linux dot vnet dot ibm dot com> <m6bvp4$tus$1 at ger dot gmane dot org> <mvmsigmpfku dot fsf at hawking dot suse dot de> <m6c0u2$o15$1 at ger dot gmane dot org> <54898F5B dot 2000904 at linux dot vnet dot ibm dot com> <5489925D dot 5010609 at linux dot vnet dot ibm dot com> <alpine dot DEB dot 2 dot 10 dot 1412111432180 dot 19830 at digraph dot polyomino dot org dot uk> <5489B83F dot 6070007 at linux dot vnet dot ibm dot com>
>> * Do you actually need this here, or only around the use of the
variable?
>
> Yes, in my testing we need on both places to silent the compiler.
On s390x, too.
+ by "*thisresplenp = rlen;" will be executed so that subsequent
+ times round the loop resplen has been initialized. So this is
After "So this is" is a whitespace.
+ a false-positive.
+ */
+#if __GNUC_PREREQ (4, 7)
+ DIAG_PUSH_NEEDS_COMMENT;
tested on s390x with gcc 4.8 4.9, gcc head.
Thanks.