This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Removal of duplication of -frounding-math for math tests

From: Andrew Senkevich <andrew dot n dot senkevich at gmail dot com>
To: Joseph Myers <joseph at codesourcery dot com>
Cc: libc-alpha <libc-alpha at sourceware dot org>
Date: Mon, 8 Dec 2014 15:32:10 +0400
Subject: Re: [PATCH] Removal of duplication of -frounding-math for math tests
Authentication-results: sourceware.org; auth=none
References: <CAMXFM3v7Y9iHcVsXa9Fj3pSSt+BpMFw2DAJU3mydtAAWbYGUeg at mail dot gmail dot com> <alpine dot DEB dot 2 dot 10 dot 1412052235120 dot 9235 at digraph dot polyomino dot org dot uk>

2014-12-06 1:36 GMT+03:00 Joseph Myers <joseph@codesourcery.com>:
> OK with a proper ChangeLog entry (which means naming each variable
> changed, along the lines of

        * math/Makefile (CFLAGS-test-float.c): Remove -frounding-math.
        (CFLAGS-test-double.c): Likewise.
        (CFLAGS-test-ldouble.c): Likewise.
        (CPPFLAGS-test-ifloat.c): Likewise.
        (CPPFLAGS-test-idouble.c): Likewise.
        (CPPFLAGS-test-ildoubl.c): Likewise.
        (CFLAGS-test-test-fenv.c): Remove variable.
        (CFLAGS-test-misc.c): Likewise.

diff --git a/math/Makefile b/math/Makefile
index 866bc0f..9ec450b 100644
--- a/math/Makefile
+++ b/math/Makefile
@@ -126,9 +126,9 @@ $(objpfx)test-ldouble.o: $(objpfx)libm-test.stmp
 $(objpfx)test-ildoubl.o: $(objpfx)libm-test.stmp
 endif

-CFLAGS-test-float.c = -fno-inline -ffloat-store -fno-builtin -frounding-math
-CFLAGS-test-double.c = -fno-inline -ffloat-store -fno-builtin -frounding-math
-CFLAGS-test-ldouble.c = -fno-inline -ffloat-store -fno-builtin -frounding-math
+CFLAGS-test-float.c = -fno-inline -ffloat-store -fno-builtin
+CFLAGS-test-double.c = -fno-inline -ffloat-store -fno-builtin
+CFLAGS-test-ldouble.c = -fno-inline -ffloat-store -fno-builtin
 CFLAGS-test-tgmath.c = -fno-builtin
 # The following testcase uses very long lines (>3 million), so it may take a
 # while to compile it. See: http://llvm.org/bugs/show_bug.cgi?id=14106 and
@@ -136,15 +136,12 @@ CFLAGS-test-tgmath.c = -fno-builtin
 CFLAGS-test-tgmath2.c = -fno-builtin
 CFLAGS-test-tgmath-ret.c = -fno-builtin
 CFLAGS-test-powl.c = -fno-builtin
-CFLAGS-test-test-fenv.c = -frounding-math
-CFLAGS-test-misc.c = -frounding-math
 CPPFLAGS-test-ifloat.c = -U__LIBC_INTERNAL_MATH_INLINES -D__FAST_MATH__ \
-                        -DTEST_FAST_MATH -fno-builtin -frounding-math
+                        -DTEST_FAST_MATH -fno-builtin
 CPPFLAGS-test-idouble.c = -U__LIBC_INTERNAL_MATH_INLINES -D__FAST_MATH__ \
-                        -DTEST_FAST_MATH -fno-builtin -frounding-math
+                        -DTEST_FAST_MATH -fno-builtin
 CPPFLAGS-test-ildoubl.c = -U__LIBC_INTERNAL_MATH_INLINES -D__FAST_MATH__ \
-                         -DTEST_FAST_MATH -fno-builtin -frounding-math
-
+                         -DTEST_FAST_MATH -fno-builtin

 # The -lieee module sets the _LIB_VERSION_ switch to IEEE mode
 # for error handling in the -lm functions.

Ok for trunk?


--
WBR,
Andrew

Attachment: remove-frounding-math.patch
Description: Binary data

Follow-Ups:
- Re: [PATCH] Removal of duplication of -frounding-math for math tests
  - From: Joseph Myers

References:
- [PATCH] Removal of duplication of -frounding-math for math tests
  - From: Andrew Senkevich
- Re: [PATCH] Removal of duplication of -frounding-math for math tests
  - From: Joseph Myers

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]