This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] fix to malloc checking

On Wed, Nov 26, 2014 at 02:30:48PM -0500, James Lemke wrote:
> On 11/26/2014 04:40 AM, Will Newton wrote:
> >This looks ok to me, although there are some minor style issues, e.g.:
> >
> >There should be a space after casts.
> >There's a bracket on its own that should be moved onto the line above.
> >A couple of if statements have some leading space that should not be there.
> 
> Thanks for the review.  This version fixes the style issues above.
> Unless anyone has other issues I will commit this version.
> Jim.
> 
> -- 
> Jim Lemke, GNU Tools Sourcerer
> Mentor Graphics / CodeSourcery

> 2014-11-26  James Lemke  <jwlemke@codesourcery.com>
> 
> 	[BZ #17581]
> 	* malloc/hooks.c
> 	(mem2mem_check): Add a terminator to the chain of checking blocks.
> 	(malloc_check_get_size): Use it here.
> 	(mem2chunk_check): Ditto.
> 

Looks OK to me.

Siddhesh

Attachment: pgpb8dOefedsm.pgp
Description: PGP signature

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]