This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [RFC] atomics vs. uniprocessor builds
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Torvald Riegel <triegel at redhat dot com>
- Cc: GLIBC Devel <libc-alpha at sourceware dot org>
- Date: Tue, 25 Nov 2014 16:36:13 +0000
- Subject: Re: [RFC] atomics vs. uniprocessor builds
- Authentication-results: sourceware.org; auth=none
- References: <1416916695 dot 1771 dot 208 dot camel at triegel dot csb>
On Tue, 25 Nov 2014, Torvald Riegel wrote:
> My guess would be that uniprocessor builds are rarely used, so it might
> be fine to just drop the UP optimization on the atomics. Keeping the
Yes. More generally: conditionals that are not active for any in-tree
glibc configuration (possibly together with documented configure options),
and are not in code shared with other projects such as gnulib, libgcc,
gettext, GMP, should be presumed dead and can be removed in the absence of
concrete reasons to keep them (e.g. if the conditional serves a useful
purpose as documentation of what the requirements of the code are, where a
new port might plausibly need to implement something new - a conditional
that causes a build failure for a system with 128-bit intmax_t might make
sense to keep, one that verifies int is at least 32-bit wouldn't outside
of shared code).
So I think all UP conditionals should be removed.
--
Joseph S. Myers
joseph@codesourcery.com