This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: Add macros for diagnostic control, use them in locale/weightwc.h
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Andreas Schwab <schwab at suse dot de>
- Cc: Paul Eggert <eggert at cs dot ucla dot edu>, Roland McGrath <roland at hack dot frob dot com>, <libc-alpha at sourceware dot org>
- Date: Wed, 19 Nov 2014 15:41:56 +0000
- Subject: Re: Add macros for diagnostic control, use them in locale/weightwc.h
- Authentication-results: sourceware.org; auth=none
- References: <alpine dot DEB dot 2 dot 10 dot 1411181803130 dot 11642 at digraph dot polyomino dot org dot uk> <546BB1B1 dot 50000 at cs dot ucla dot edu> <20141118211808 dot 2053D2C3B22 at topped-with-meat dot com> <546BC831 dot 2010006 at cs dot ucla dot edu> <alpine dot DEB dot 2 dot 10 dot 1411182301110 dot 18922 at digraph dot polyomino dot org dot uk> <546BDD19 dot 6000908 at cs dot ucla dot edu> <alpine dot DEB dot 2 dot 10 dot 1411190004060 dot 18922 at digraph dot polyomino dot org dot uk> <mvm4mtvy2te dot fsf at hawking dot suse dot de>
On Wed, 19 Nov 2014, Andreas Schwab wrote:
> Joseph Myers <joseph@codesourcery.com> writes:
>
> > This is the one such optimization-related warning I see on x86_64
>
> This is the only other case I see:
>
> res_send.c:794:8: warning: 'resplen' may be used uninitialized in this function [-Wmaybe-uninitialized]
I've seen that on other architectures. My proposal is to get the build
and test clean with -Werror (or -Werror -Wno-error=undef if the -Wundef
fixes aren't all in on time) for a single (architecture, compiler) pair,
before adding the configuration support for enabling -Werror by default
with --disable-werror to disable it and leaving it to people seeing other
warnings to fix them or add the macros calling the pragmas as appropriate.
--
Joseph S. Myers
joseph@codesourcery.com