This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [ping3][PATCH 01/19 v2] Add new macro IN_MODULE to identify module in which source is built


On Fri, Nov 07, 2014 at 03:22:10PM -0800, Roland McGrath wrote:
> > +# Set libof-* for each routine.
> > -CPPFLAGS-locale-programs = -DLOCALE_PATH='$(localepath)' \
> > +CPPFLAGS-locale_programs = -DLOCALE_PATH='$(localepath)' \
> 
> Rather than changing this name, I think the libc-modules.h generation
> should just turn all nonidentifier characters into _.

Doing that for libc-modules.h is easy, but it will be hard to do that
in Makeconfig to set -DIN_MODULE=MODULE_* because I don't think there
is a straightforward way to do regex substitutions in GNU make.  I
could just use subst to just replace the - with _, but then wouldn't
it make sense to just restrict module names to always have only valid
identifier characters instead?

Siddhesh

Attachment: pgpy1Nu4E7i2t.pgp
Description: PGP signature


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]