This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 29/29] [AARCH64] Make lp64 and ilp32 directories.
- From: "Joseph S. Myers" <joseph at codesourcery dot com>
- To: Andrew Pinski <apinski at cavium dot com>
- Cc: <libc-alpha at sourceware dot org>
- Date: Mon, 27 Oct 2014 18:07:29 +0000
- Subject: Re: [PATCH 29/29] [AARCH64] Make lp64 and ilp32 directories.
- Authentication-results: sourceware.org; auth=none
- References: <1414396793-9005-1-git-send-email-apinski at cavium dot com> <1414396793-9005-30-git-send-email-apinski at cavium dot com>
On Mon, 27 Oct 2014, Andrew Pinski wrote:
> The patch makes the ilp32 and lp64 have their own directory under aarch64.
> Since ILP32 uses most of the same system calls as LP64 and has a 64bit
> off_t, we need make the functions that end in 64 the same as the ones without.
> We also need not to special case ioctl or use the already provided mmap.c file.
I'd expect you to need to move the ABI test baselines to the lp64
directory, and to add new baselines for ILP32 in the corresponding
directory, but I don't see that in this patch series. What do your glibc
test results look like? (I don't know if c++-types.data needs to move and
have an ILP32 version as well, but I'd guess at least some affected types
are different and so it does.)
--
Joseph S. Myers
joseph@codesourcery.com