This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [RFC][PATCH] Adjust most tests to use test-skeleton.c
- From: Roland McGrath <roland at hack dot frob dot com>
- To: Arjun Shankar <arjun dot is at lostca dot se>
- Cc: libc-alpha at sourceware dot org
- Date: Tue, 21 Oct 2014 10:23:59 -0700 (PDT)
- Subject: Re: [RFC][PATCH] Adjust most tests to use test-skeleton.c
- Authentication-results: sourceware.org; auth=none
- References: <20141021121711 dot GA44276 at arati dot lostca dot se>
> Is it horrible to try and hammer the glibc source tree with a bit of `sed'?
However you arrive at your changes is up to you. It's the changes
themselves we review. When you used a script it is very helpful to post
it and describe the procedure you followed, as you have done. So that's
all great. Most of these changes look just fine to me off hand, but
they need ChangeLog entries to match; they are just as easy to generate
programmatically as the source changes.
It's easier to review and sign off on a large set of changes if they are
all completely formulaic. So start with one big patch that is only the
completely trivial cases. Then for each case where you found you needed
to set TIMEOUT or something else beyond the basic mechanical change,
post each of those separately for review and discussion.
Thanks,
Roland