This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [RFC] pthread_once: Use unified variant instead of custom x86_64/i386
- From: Torvald Riegel <triegel at redhat dot com>
- To: Roland McGrath <roland at hack dot frob dot com>
- Cc: GLIBC Devel <libc-alpha at sourceware dot org>, andi <andi at firstfloor dot org>
- Date: Mon, 20 Oct 2014 21:35:13 +0200
- Subject: Re: [RFC] pthread_once: Use unified variant instead of custom x86_64/i386
- Authentication-results: sourceware.org; auth=none
- References: <1381523328 dot 18547 dot 3422 dot camel at triegel dot csb> <1396878469 dot 10643 dot 8959 dot camel at triegel dot csb> <1413751577 dot 8483 dot 27 dot camel at triegel dot csb> <20141020013717 dot 08E272C3A86 at topped-with-meat dot com> <1413822987 dot 8483 dot 41 dot camel at triegel dot csb> <20141020181806 dot 272EF2C3B0D at topped-with-meat dot com>
On Mon, 2014-10-20 at 11:18 -0700, Roland McGrath wrote:
> > + return __pthread_once_slow 23(once_control, init_routine);
>
> All looks good except this stray "23". Its presence suggests you didn't
> test the final version of the patch you posted, which you need to do before
> committing.
Oops, sorry. Yes, I didn't test after the whitespace fixes (but
before). I'll make a note to self...
Committed after testing on x86_64.