This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
RE: [PATCHv3, MIPS] Add support for O32 FPXX and program header based ABI information
- From: Matthew Fortune <Matthew dot Fortune at imgtec dot com>
- To: "Joseph S. Myers" <joseph at codesourcery dot com>
- Cc: "'libc-alpha at sourceware dot org'" <libc-alpha at sourceware dot org>, "Moore, Catherine (Catherine_Moore at mentor dot com)" <Catherine_Moore at mentor dot com>, "'Andrew Pinski'" <pinskia at gmail dot com>, "Rich Felker (dalias at libc dot org)" <dalias at libc dot org>, Rich Fuhler <Rich dot Fuhler at imgtec dot com>, "'macro at codesourcery dot com'" <macro at codesourcery dot com>
- Date: Sun, 19 Oct 2014 07:30:02 +0000
- Subject: RE: [PATCHv3, MIPS] Add support for O32 FPXX and program header based ABI information
- Authentication-results: sourceware.org; auth=none
- References: <6D39441BF12EF246A7ABCE6654B0235320F1A039 at LEMAIL01 dot le dot imgtec dot org> <Pine dot LNX dot 4 dot 64 dot 1410022033580 dot 21905 at digraph dot polyomino dot org dot uk> <6D39441BF12EF246A7ABCE6654B0235320F1EEE5 at LEMAIL01 dot le dot imgtec dot org> <Pine dot LNX dot 4 dot 64 dot 1410072108360 dot 17516 at digraph dot polyomino dot org dot uk> <6D39441BF12EF246A7ABCE6654B0235320F2BEE7 at LEMAIL01 dot le dot imgtec dot org> <Pine dot LNX dot 4 dot 64 dot 1410172051110 dot 14369 at digraph dot polyomino dot org dot uk>
Joseph S. Myers <joseph@codesourcery.com> writes:
> On Fri, 17 Oct 2014, Matthew Fortune wrote:
>
> > 4) Prevent loading objects with unknown ASEs. Also reject MSA in the
> > absence of new HWCAP bits. Other ASEs are not rejected despite
> > the lack of HWCAPs as they have historically been loaded
> > unconditionally
>
> Given the deferrment of the HWCAP addition until the values are in the
> kernel, this needs to be taken out to be considered later once HWCAPs are
> in. (More generally, please make clear what the patch depends on that
> isn't in current glibc master, and make sure to ping any such patches that
> haven't been reviewed. I think you're depending on a libc-abis patch, at
> least.)
The patch is not dependent on the HWCAP patch. I have hardcoded the logic
to assume that the HWCAPs are never set. This simply means that any ASE
which was defined before MSA is accepted and anything from MSA to any
future ASE is rejected.
The patch is dependent on...
Create a hook for inspecting program headers during library load. Roland has
said OK to this but I am holding off getting it committed until this patch
is OK just in case something has to change in the hook:
http://sourceware.org/ml/libc-alpha/2014-10/msg00352.html
Moving MIPS libc-abis to the top-level (but this dependency can easily be
removed if removing the file causes problems).
http://sourceware.org/ml/libc-alpha/2014-10/msg00018.html
Thanks,
Matthew