This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: Don't use INTUSE with __adjtimex (bug 14132)

From: Siddhesh Poyarekar <siddhesh at redhat dot com>
To: "Joseph S. Myers" <joseph at codesourcery dot com>
Cc: libc-alpha at sourceware dot org, Richard Henderson <rth at twiddle dot net>
Date: Wed, 8 Oct 2014 20:53:48 +0530
Subject: Re: Don't use INTUSE with __adjtimex (bug 14132)
Authentication-results: sourceware.org; auth=none
References: <Pine dot LNX dot 4 dot 64 dot 1410081510530 dot 30476 at digraph dot polyomino dot org dot uk>

On Wed, Oct 08, 2014 at 03:12:39PM +0000, Joseph S. Myers wrote:
> Bug 14132 is removal of the old INTDEF/INTUSE system of *_internal
> aliases as obsoleted by the hidden_proto / hidden_def system.  Various
> cases were cleaned up in 2012, but some remain.  This patch removes
> the use of this mechanism for __adjtimex.
> 
> Tested for x86_64 that stripped installed shared libraries are
> unchanged by the patch.
> 
> 2014-10-08  Joseph Myers  <joseph@codesourcery.com>
> 
> 	[BZ #14132]
> 	* sysdeps/unix/sysv/linux/include/sys/timex.h: New file.
> 	* sysdeps/unix/sysv/linux/adjtime.c [!ADJTIMEX] (ADJTIMEX): Do not
> 	use INTUSE.
> 	[!ADJTIMEX] (INTUSE(__adjtimex)): Remove declaration.
> 	* sysdeps/unix/sysv/linux/alpha/adjtime.c (__adjtimex_internal):
> 	Remove alias.
> 	(__adjtimex): Define using libc_hidden_ver.
> 	* sysdeps/unix/sysv/linux/ntp_gettime.c (INTUSE(__adjtimex)):
> 	Remove declaration.
> 	(ntp_gettime): Call __adjtimex directly.
> 	* sysdeps/unix/sysv/linux/ntp_gettimex.c (INTUSE(__adjtimex)):
> 	Remove declaration.
> 	(ntp_gettimex): Call __adjtimex directly.
> 	* sysdeps/unix/sysv/linux/syscalls.list (adjtimex): Remove
> 	__adjtimex_internal alias.
> 

Looks OK to me.

Siddhesh

Attachment: pgpwSp_eG6GDu.pgp
Description: PGP signature

References:
- Don't use INTUSE with __adjtimex (bug 14132)
  - From: Joseph S. Myers

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]