This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] stdlib/tst-strtod-round.c: Fix build on ARM
- From: "Joseph S. Myers" <joseph at codesourcery dot com>
- To: Siddhesh Poyarekar <siddhesh at redhat dot com>
- Cc: Will Newton <will dot newton at linaro dot org>, <libc-alpha at sourceware dot org>
- Date: Wed, 24 Sep 2014 15:28:38 +0000
- Subject: Re: [PATCH] stdlib/tst-strtod-round.c: Fix build on ARM
- Authentication-results: sourceware.org; auth=none
- References: <1410903170-31206-1-git-send-email-will dot newton at linaro dot org> <1410903170-31206-2-git-send-email-will dot newton at linaro dot org> <20140924145915 dot GO1716 at spoyarek dot pnq dot redhat dot com> <20140924150331 dot GQ1716 at spoyarek dot pnq dot redhat dot com> <Pine dot LNX dot 4 dot 64 dot 1409241512230 dot 8603 at digraph dot polyomino dot org dot uk> <20140924151944 dot GR1716 at spoyarek dot pnq dot redhat dot com>
On Wed, 24 Sep 2014, Siddhesh Poyarekar wrote:
> On Wed, Sep 24, 2014 at 03:13:17PM +0000, Joseph S. Myers wrote:
> > I don't see why - it's not a bug that was user-visible in a release.
> > User programs, which should never define _LIBC or _LIBC_TEST, will have
> > got the required declarations anyway.
>
> There's a build component in bugzilla that exists for exactly such
> bugs. It could be argued that it's a test failure and not a build
> failure, but then most distributions (and people) have the test run as
> part of their workflow and a test failure may in some cases result in
> a build failure.
But it's not a test failure in a release either (and the point of filing a
bug when fixing it is for users of releases to be able to find fixed bugs
when searching Bugzilla; anyone using git master should be following
libc-alpha). It's build warnings (the functions get the right types
anyway, being built-in). The use of -Werror=implicit-function-declaration
postdates the last release.
--
Joseph S. Myers
joseph@codesourcery.com