This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v2] __builtin_expect cleanup for iconv{,data}/*.c
- From: Florian Weimer <fweimer at redhat dot com>
- To: Roland McGrath <roland at hack dot frob dot com>, "Carlos O'Donell" <carlos at redhat dot com>
- Cc: Kalle Olavi Niemitalo <kon at iki dot fi>, libc-alpha <libc-alpha at sourceware dot org>
- Date: Tue, 23 Sep 2014 13:24:43 +0200
- Subject: Re: [PATCH v2] __builtin_expect cleanup for iconv{,data}/*.c
- Authentication-results: sourceware.org; auth=none
- References: <540E06B0 dot 50406 at redhat dot com> <540F501B dot 2080808 at redhat dot com> <87ha0g4adb dot fsf at Niukka dot kon dot iki dot fi> <541001AC dot 50107 at redhat dot com> <87bnqn4b25 dot fsf at Niukka dot kon dot iki dot fi> <20140910180713 dot D39B72C39CB at topped-with-meat dot com> <54125038 dot 1040109 at redhat dot com> <20140912175231 dot 301EB2C3981 at topped-with-meat dot com>
On 09/12/2014 07:52 PM, Roland McGrath wrote:
I forgot to mention the other exception: if (foo & BIT) or if (!(foo & BIT))
is fine, no need for if ((foo & BIT) != 0) or if ((foo & BIT) == 0).
Thanks, so there shouldn't be a need to change the patch.
--
Florian Weimer / Red Hat Product Security