This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Fix crashes on invalid input in IBM gconv modules [BZ #17325]
- From: Roland McGrath <roland at hack dot frob dot com>
- To: Andreas Schwab <schwab at linux-m68k dot org>
- Cc: Florian Weimer <fweimer at redhat dot com>, GNU C Library <libc-alpha at sourceware dot org>, azanella at linux dot vnet dot ibm dot com
- Date: Fri, 29 Aug 2014 14:54:48 -0700 (PDT)
- Subject: Re: [PATCH] Fix crashes on invalid input in IBM gconv modules [BZ #17325]
- Authentication-results: sourceware.org; auth=none
- References: <54006E57 dot 8030800 at redhat dot com> <87y4u7o1yr dot fsf at igel dot home>
> Florian Weimer <fweimer@redhat.com> writes:
>
> > + if (__builtin_expect (rp2->start == 0xffff, 0) \
>
> Please use either this
>
> > + if (__builtin_expect (ch == 0xffff, 0) \
>
> or this consistently.
Use neither. Use __glibc_{un,}likely consistently.