This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v1.1] __gconv_translit_find: Actually append ".so" to module name [BZ #17187]


On 26/08/14 19:52, Florian Weimer wrote:
> On 08/26/2014 08:35 AM, Siddhesh Poyarekar wrote:
> 
>> I think this fix is fine (except a minor nit below), but it would be
> 
> Thanks.
> 
>> good if another maintainer also verifies that it won't break anything.
>> Also, Allan needs to ack it for 2.20.  I am going to put the patch in
>> rawhide today anyway, so I'll report back if there are any issues; I
>> don't expect any though.
> 
> Okay, I will reword the comment.
> 
> Allan, is this okay for 2.20/current master?
> 

I'd like the "if another maintainer also verifies that it won't break
anything" to be enacted.  My best guess is that it is fine and given
there is an exploit it should go in, but I am not confident enough about
lack of side effects.

Can someone else give this an ack?  Roland, Carlos, Joseph, etc?

Once that is done, it is fine to commit to master.

Allan


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]