Re: [PATCH] Added icmp6 options and router preference

[Dan LÃdtke <mail at danrl dot de>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Hi guys,

Please merge! I claim no copyright whatsoever. This is all public RFC
I just translated into C. These changes are needed! The software using
the changes is already in the Fedora repos with a workaround.

https://github.com/danrl/ratools/blob/master/src/ratools.h#L30

Cheers

Dan

On 08/02/2014 05:29 PM, Mike Frysinger wrote:
> On Tue 22 Apr 2014 12:21:16 OndÅej BÃlka wrote:
>> On Tue, Apr 22, 2014 at 11:54:56AM +0200, Florian Weimer wrote:
>>> On 03/31/2014 12:01 PM, Dan Luedtke wrote:
>>>> Hi Florian, OndÅej, @list,
>>>> 
>>>> On Mon, 2014-03-31 at 09:18 +0200, Florian Weimer wrote:
>>>>> There is precedent for ND_OPT_ARO instead.
>>>> 
>>>> I am fine with that! Looks better that the long version.
>>> 
>>> It doesn't seem like this was applied.  Do we need copyright 
>>> assignment for a change with such limited scope?
>> 
>> I asked if you have additional comments, you could commit it if
>> you want.
>> 
>> Typically copyrigth assignment is not needed when total changes 
>> of person are below 15 lines.
> 
> well, the diffstat shows that it's more than 2x the number you
> stated
> 
> but the "small line count" is really a simplified rule of thumb for
> the idea that copyright assignment papers are not required when the
> change is not deemed copyrightable.  i think this is such a case as
> it's merely adding defines for existing standards to a public API
> header.
> 
> so if everyone is happy, shall we merge ? -mike
> 

- -- 
Dan LÃdtke
https://www.danrl.de/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iF4EAREIAAYFAlPdDO0ACgkQg7qmx/JyvfyaqAD8CirilfStPMpX5a38LK+HmD8G
Qgtb5IyR6rR0O6nMfqIBAJw4bbiVZdr+Mua7GfuhqKziXllBvbEETVsPmQXn7Gyx
=O112
-----END PGP SIGNATURE-----