This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH, AArch64] Detect assembler vector mov parsing bug
- From: Will Newton <will dot newton at linaro dot org>
- To: Richard Henderson <rth at twiddle dot net>
- Cc: GNU C Library <libc-alpha at sourceware dot org>, "Carlos O'Donell" <codonell at redhat dot com>
- Date: Wed, 23 Jul 2014 14:55:41 +0100
- Subject: Re: [PATCH, AArch64] Detect assembler vector mov parsing bug
- Authentication-results: sourceware.org; auth=none
- References: <53C43559 dot 5000907 at twiddle dot net>
On 14 July 2014 20:54, Richard Henderson <rth@twiddle.net> wrote:
> The strchr implementation that was recently committed to mainline tickles an
> assembler bug fixed by
>
> commit 8db49cc2de52033990ae5d4d6aacedc8f986e803
> Author: Will Newton <will.newton@linaro.org>
> Date: Thu Oct 31 17:21:11 2013 -0700
>
> config/tc-aarch64.c: Avoid trying to parse a vector mov as immediate.
> ...
>
> Obviously not a problem with a relatively new binutils installed, but Carlos
> ran into this problem building mainline glibc on a system using binutils 2.23.
>
> It's not a silent error (we die linking ld.so), but its somewhat cryptic.
> Carlos opined to me that we ought to error out at configure time with an
> understandable message.
>
> Rather than check for version numbers, let's check for functionality.
>
> Ok?
This looks ok to me, although it might be nice to mention that 2.24 is
a version containing the fix.
--
Will Newton
Toolchain Working Group, Linaro