This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] un-nest findidx()
- From: Konstantin Serebryany <konstantin dot s dot serebryany at gmail dot com>
- To: Roland McGrath <roland at hack dot frob dot com>
- Cc: GNU C Library <libc-alpha at sourceware dot org>
- Date: Thu, 3 Jul 2014 15:56:41 +0400
- Subject: Re: [PATCH] un-nest findidx()
- Authentication-results: sourceware.org; auth=none
- References: <CAGQ9bdz9V7w+5Wn_j8CSKvweh9GkW0gU5GvB94UCP2Zn-bf8OQ at mail dot gmail dot com>
Any comments on this patch?
--kcc
On Wed, Jun 18, 2014 at 5:59 PM, Konstantin Serebryany
<konstantin.s.serebryany@gmail.com> wrote:
> Hi,
>
> Please review the patch which removes nested functions findidx and replaces them
> with two 'static inline' functions: findidx and findidxwc.
> No functionality change intended.
>
> un-nesting glibc function was previously discussed here:
> https://sourceware.org/ml/libc-alpha/2014-05/msg00400.html
>
> Thanks!
>
> --kcc
>
> 2014-06-18 Kostya Serebryany <konstantin.s.serebryany@gmail.com>
>
> * locale/weight.h: add include guard.
> (findidx): un-nest, make it static inline, add parameters.
> * locale/weightwc.h: add include guard, rename findidx to findidxwc.
> (findidxwc): un-nest, make it static inline, add parameters.
> * posix/fnmatch_loop.c: include weightwc.h or weight.h depending on
> WIDE_CHAR_VERSION. Define FINDIDX as findidxwc or findidx.
> (FCT): change type of 'extra' to wint_t; do not include weight.h,
> un-nest calls to findidx.
> * posix/regcomp.c: include weight.h.
> (build_equiv_class): don't include weight.h, un-nest findidx.
> * posix/regex_internal.h: include weight.h
> (re_string_elem_size_at): don't include weight.h, un-nest findidx.
> * posix/regexec.c: include weight.h.
> (check_node_accept_bytes): don't include weight.h, un-nest findidx.
> * string/strcoll_l.c: define FINDIDX, include WEIGHT_H.
> (get_next_seq): don't include WEIGHT_H, un-nest findidx.
> (get_next_seq_nocache): don't include WEIGHT_H, un-nest findidx.
> * string/strxfrm_l.c: define FINDIDX, include WEIGHT_H.
> (STRXFRM): don't include WEIGHT_H, un-nest findidx.
> * wcsmbs/wcscoll_l.c: define FINDIDX.
> * wcsmbs/wcsxfrm_l.c: define FINDIDX.