Re: [PATCH] Remove MULTI_PTRS_ARE_ALIASES to fix Wundef warning

[Siddhesh Poyarekar <siddhesh at redhat dot com>]

On Fri, Jun 27, 2014 at 02:20:45PM -0400, Carlos O'Donell wrote:
> OK because it's been this way so long.
> 

Not committing this yet since Roland also raised doubts about the
inconsistency.  Lets try to get that resolved first.

> Do we have a bug here?
> 
> If the DNS server has multiple PTR records do we return them all?
> 
> I think we should since DNS doesn't make it invalid.

It is inconsistent behaviour between getnameinfo and gethostbyaddr,
but I dont know if we ought to be fixing it now, which is why I went
with retaining old behaviour instead.

Why would multiple PTR records be useful for getnameinfo (or
gethostbyaddr for that matter)?  getnameinfo is capable of returning
only one name, so running through an entire list seems useless.  A
regular lookup won't expect a PTR record AFAICT.

So I would think that getnameinfo behaviour is not incorrect and
gethostbyaddr behaviour (it being a legacy function) be left alone.

Siddhesh

Attachment: pgp_bzqgXs7nz.pgp
Description: PGP signature