This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 1/4] resolv: improve comments about nserv and nservall
- From: Aurelien Jarno <aurelien at aurel32 dot net>
- To: Siddhesh Poyarekar <siddhesh at redhat dot com>
- Cc: libc-alpha at sourceware dot org
- Date: Thu, 19 Jun 2014 17:53:37 +0200
- Subject: Re: [PATCH 1/4] resolv: improve comments about nserv and nservall
- Authentication-results: sourceware.org; auth=none
- References: <1402673533-13243-1-git-send-email-aurelien at aurel32 dot net> <1402673533-13243-2-git-send-email-aurelien at aurel32 dot net> <20140618091224 dot GF7238 at spoyarek dot pnq dot redhat dot com> <20140618162831 dot GF24904 at hall dot aurel32 dot net> <20140619095141 dot GN7238 at spoyarek dot pnq dot redhat dot com>
On Thu, Jun 19, 2014 at 03:21:42PM +0530, Siddhesh Poyarekar wrote:
> On Wed, Jun 18, 2014 at 06:28:31PM +0200, Aurelien Jarno wrote:
> > Thanks for your ack. My plan is to commit the 4 patches at the same
> > time, as they are linked. I am waiting for the review of the 3 other
> > patches, unless I am mistaken and that this ack is for the whole series.
>
> They're linked, but not dependent, but it's your personal preference I
> guess. My concern is that it breaks the patchwork workflow, since
> you're resent the acked patch again. I haven't looked at the other
> patches to see if they're changed, but if they're not and your
> intention was to just ping the patches, then I'd suggest using the
> method everyone else is using, which is to add [ping] to the subject
> line in reply to your original submission instead of resending the
> patch, since the latter adds an additional patch to review in
> patchwork.
One of the patch has changed, all the others got improved description
and a changelog entry. But more importantly the first version was
clearly an RFC, one of the main change between the two is that I am now
convinced it's the right thing to do.
> That, or help maintain the patchwork reviews, and I'd really be glad
> if you choose the latter :)
Yes, in that case I could simply flag the patch as superseded in
patchworks. I have just created an account, so that I can do that next
time.
--
Aurelien Jarno GPG: 4096R/1DDD8C9B
aurelien@aurel32.net http://www.aurel32.net